RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 05:48:12 +00:00
Code Issues Activity Actions

LibWeb: Remove StringBuilder from HTMLToken::m_comment_or_character

Browse source
This commit is contained in:
Gunnar Beutner 2021-05-23 09:31:40 +02:00 • committed by Andreas Kling
parent 3aa202c432
commit c3ad8e9a52
5 changed files with 54 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/HTML/Parser/HTMLToken.h
View file

@ -8,7 +8,6 @@
#include <AK/FlyString.h>
#include <AK/String.h>
#include <AK/StringBuilder.h>
#include <AK/Types.h>
#include <AK/Utf8View.h>
#include <AK/Vector.h>
@ -34,7 +33,10 @@ public:
{
HTMLToken token;
token.m_type = Type::Character;
token.m_comment_or_character.data.append(code_point);
StringBuilder builder;
// FIXME: This narrows code_point to char, should this be append_code_point() instead?
builder.append(code_point);
token.m_comment_or_character.data = builder.to_string();
return token;
}
@ -56,7 +58,7 @@ public:
u32 code_point() const
{
VERIFY(is_character());
Utf8View view(m_comment_or_character.data.string_view());
Utf8View view(m_comment_or_character.data);
VERIFY(view.length() == 1);
return *view.begin();
}
@ -209,7 +211,7 @@ private:
// Type::Comment
// Type::Character
struct {
StringBuilder data;
String data;
} m_comment_or_character;
Position m_start_position;