RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-16 19:05:08 +00:00
Code Issues Activity Actions

LibGUI: Make SortingProxyModel update all view cursors on resort

Browse source 
Otherwise they will be stale indexes, which is no good. :^)
This commit is contained in:
Andreas Kling 2020-08-29 00:18:35 +02:00
parent fed53e19c7
commit c3b3a078f3
1 changed files with 14 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Libraries/LibGUI/SortingProxyModel.cpp
View file

@ -51,6 +51,7 @@ void SortingProxyModel::invalidate(unsigned int flags)
// FIXME: This is really harsh, but without precise invalidation, not much we can do.
for_each_view([&](auto& view) {
view.set_cursor({}, AbstractView::SelectionUpdate::None);
view.selection().clear();
});
}
@ -201,6 +202,19 @@ void SortingProxyModel::sort_mapping(Mapping& mapping, int column, SortOrder sor
// FIXME: I really feel like this should be done at the view layer somehow.
for_each_view([&](AbstractView& view) {
// Update the view's cursor.
auto cursor = view.cursor_index();
if (cursor.is_valid() && cursor.parent() == mapping.source_parent) {
for (size_t i = 0; i < mapping.source_rows.size(); ++i) {
if (mapping.source_rows[i] == view.cursor_index().row()) {
auto new_source_index = this->index(i, view.cursor_index().column(), mapping.source_parent);
view.set_cursor(new_source_index, AbstractView::SelectionUpdate::None, false);
break;
}
}
}
// Update the view's selection.
view.selection().change_from_model({}, [&](ModelSelection& selection) {
Vector<ModelIndex> selected_indexes_in_source;
Vector<ModelIndex> stale_indexes_in_selection;