RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 18:42:43 +00:00
Code Issues Activity Actions

Kernel/Storage: Remove InterfaceType enum

Browse source 
This enum was created to help put distinction between the commandset and
the interface type, as ATAPI devices are simply ATA devices utilizing
the SCSI commandset. Because we don't support ATAPI, putting such type
of distinction is pointless, so let's remove this for now.
This commit is contained in:
Liav A 2022-08-05 13:36:10 +03:00 • committed by Linus Groh
parent c85f81bc9d
commit c3eaa73113
8 changed files with 5 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Kernel/FileSystem/SysFS/Subsystems/Devices/Storage/DeviceAttribute.cpp
View file

@ -21,8 +21,6 @@ StringView StorageDeviceAttributeSysFSComponent::name() const
return "sector_size"sv;
case Type::CommandSet:
return "command_set"sv;
case Type::InterfaceType:
return "interface_type"sv;
default:
VERIFY_NOT_REACHED();
}
@ -65,9 +63,6 @@ ErrorOr<NonnullOwnPtr<KBuffer>> StorageDeviceAttributeSysFSComponent::try_to_gen
case Type::CommandSet:
value = TRY(KString::formatted("{}", m_device->command_set_to_string_view()));
break;
case Type::InterfaceType:
value = TRY(KString::formatted("{}", m_device->interface_type_to_string_view()));
break;
default:
VERIFY_NOT_REACHED();
}

1
Kernel/FileSystem/SysFS/Subsystems/Devices/Storage/DeviceAttribute.h
View file

@ -18,7 +18,6 @@ public:
EndLBA,
SectorSize,
CommandSet,
InterfaceType,
};
public:

1
Kernel/FileSystem/SysFS/Subsystems/Devices/Storage/DeviceDirectory.cpp
View file

@ -29,7 +29,6 @@ UNMAP_AFTER_INIT NonnullRefPtr<StorageDeviceSysFSDirectory> StorageDeviceSysFSDi
list.append(StorageDeviceAttributeSysFSComponent::must_create(*directory, StorageDeviceAttributeSysFSComponent::Type::EndLBA));
list.append(StorageDeviceAttributeSysFSComponent::must_create(*directory, StorageDeviceAttributeSysFSComponent::Type::SectorSize));
list.append(StorageDeviceAttributeSysFSComponent::must_create(*directory, StorageDeviceAttributeSysFSComponent::Type::CommandSet));
list.append(StorageDeviceAttributeSysFSComponent::must_create(*directory, StorageDeviceAttributeSysFSComponent::Type::InterfaceType));
return {};
}));
return directory;