RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 15:38:10 +00:00
Code Issues Activity Actions

LibWeb: Improve support for selecting an image source

Browse source 
Apply media conditions before selecting a size and add an algorithm to
select an image source based on pixel density.
This commit is contained in:
Andi Gallo 2023-05-28 02:04:58 +00:00 • committed by Andreas Kling
parent 29d29134ba
commit c411b5408e
2 changed files with 43 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
View file

@ -8151,9 +8151,15 @@ CSS::Length CSS::Parser::Parser::parse_as_sizes_attribute()
if (unparsed_size.is_empty())
return size.value();
// FIXME: 4. Parse the remaining component values in unparsed size as a <media-condition>.
// If it does not parse correctly, or it does parse correctly but the <media-condition> evaluates to false, continue. [MQ]
dbgln("FIXME: Implement parsing of media conditions in sizes attribute");
// 4. Parse the remaining component values in unparsed size as a <media-condition>.
// If it does not parse correctly, or it does parse correctly but the <media-condition> evaluates to false, continue.
TokenStream<ComponentValue> token_stream { unparsed_size };
auto media_condition = parse_media_condition(token_stream, MediaCondition::AllowOr::Yes);
if (media_condition && media_condition->evaluate(m_context.document()->window()) == CSS::MatchResult::True) {
return size.value();
} else {
continue;
}
}
return CSS::Length(100, CSS::Length::Type::Vw);