RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:47:45 +00:00
Code Issues Activity Actions

HackStudio: Always use relative paths when opening project files

Browse source
This commit is contained in:
Itamar 2021-02-20 12:16:32 +02:00 • committed by Andreas Kling
parent 7ecb21afa7
commit c4139be461
2 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/DevTools/HackStudio/Editor.cpp
View file

@ -431,7 +431,6 @@ void Editor::set_document(GUI::TextDocument& doc)
if (m_language_client) { if (m_language_client) {
set_autocomplete_provider(make<LanguageServerAidedAutocompleteProvider>(*m_language_client)); set_autocomplete_provider(make<LanguageServerAidedAutocompleteProvider>(*m_language_client));
dbgln("Opening {}", code_document.file_path());
int fd = open(code_document.file_path().characters(), O_RDONLY | O_NOCTTY); int fd = open(code_document.file_path().characters(), O_RDONLY | O_NOCTTY);
if (fd < 0) { if (fd < 0) {
perror("open"); perror("open");

7
Userland/DevTools/HackStudio/HackStudioWidget.cpp
View file

@ -210,8 +210,13 @@ Vector<String> HackStudioWidget::selected_file_names() const
return files; return files;
} }
void HackStudioWidget::open_file(const String& filename) void HackStudioWidget::open_file(const String& full_filename)
{ {
String filename = full_filename;
if (full_filename.starts_with(project().root_path())) {
filename = LexicalPath::relative_path(full_filename, project().root_path());
}
dbgln("HackStudio is opening {}", filename);
if (Core::File::is_directory(filename)) if (Core::File::is_directory(filename))
return; return;