RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 05:18:12 +00:00
Code Issues Activity Actions

Kernel: Always pass InodeIdentifier by value

Browse source 
These objects are small, there are no benefits to passing by reference.
This commit is contained in:
Andreas Kling 2022-01-01 22:27:24 +01:00
parent db4388f21b
commit c427f8bbeb
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/FileSystem/Inode.cpp
View file

@ -202,7 +202,7 @@ void Inode::set_metadata_dirty(bool metadata_dirty)
} }
} }
void Inode::did_add_child(InodeIdentifier const&, String const& name) void Inode::did_add_child(InodeIdentifier, String const& name)
{ {
MutexLocker locker(m_inode_lock); MutexLocker locker(m_inode_lock);
@ -211,7 +211,7 @@ void Inode::did_add_child(InodeIdentifier const&, String const& name)
} }
} }
void Inode::did_remove_child(InodeIdentifier const&, String const& name) void Inode::did_remove_child(InodeIdentifier, String const& name)
{ {
MutexLocker locker(m_inode_lock); MutexLocker locker(m_inode_lock);

4
Kernel/FileSystem/Inode.h
View file

@ -106,8 +106,8 @@ protected:
void set_metadata_dirty(bool); void set_metadata_dirty(bool);
ErrorOr<void> prepare_to_write_data(); ErrorOr<void> prepare_to_write_data();
void did_add_child(InodeIdentifier const& child_id, String const& name); void did_add_child(InodeIdentifier child_id, String const& name);
void did_remove_child(InodeIdentifier const& child_id, String const& name); void did_remove_child(InodeIdentifier child_id, String const& name);
void did_modify_contents(); void did_modify_contents();
void did_delete_self(); void did_delete_self();