RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:37:45 +00:00
Code Issues Activity Actions

WindowServer: Unbreak "pick new active window" algorithm

Browse source 
We lost the ability to pick a suitable new active window when I added
the support for tool windows.
This commit is contained in:
Andreas Kling 2021-02-17 16:52:08 +01:00
parent 6c2f0316d9
commit c4438d6fd4
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Services/WindowServer/WindowManager.cpp
View file

@ -418,7 +418,7 @@ bool WindowManager::pick_new_active_window(Window* previous_active)
bool new_window_picked = false; bool new_window_picked = false;
Window* first_candidate = nullptr; Window* first_candidate = nullptr;
for_each_visible_window_from_front_to_back([&](Window& candidate) { for_each_visible_window_from_front_to_back([&](Window& candidate) {
if (candidate.type() != WindowType::Normal && candidate.type() == WindowType::ToolWindow) if (candidate.type() != WindowType::Normal && candidate.type() != WindowType::ToolWindow)
return IterationDecision::Continue; return IterationDecision::Continue;
if (candidate.is_destroyed()) if (candidate.is_destroyed())
return IterationDecision::Continue; return IterationDecision::Continue;