mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 21:07:35 +00:00
Kernel: Change wait blocking to Process-only blocking
This prevents zombies created by multi-threaded applications and brings our model back to closer to what other OSs do. This also means that SIGSTOP needs to halt all threads, and SIGCONT needs to resume those threads.
This commit is contained in:
parent
47ede74326
commit
c455fc2030
11 changed files with 284 additions and 203 deletions
|
@ -37,7 +37,7 @@ KResultOr<u32> handle_syscall(const Kernel::Syscall::SC_ptrace_params& params, P
|
|||
{
|
||||
ScopedSpinLock scheduler_lock(g_scheduler_lock);
|
||||
if (params.request == PT_TRACE_ME) {
|
||||
if (Thread::current()->tracer())
|
||||
if (Process::current()->tracer())
|
||||
return KResult(-EBUSY);
|
||||
|
||||
caller.set_wait_for_tracer_at_next_execve(true);
|
||||
|
@ -59,11 +59,12 @@ KResultOr<u32> handle_syscall(const Kernel::Syscall::SC_ptrace_params& params, P
|
|||
|| (peer->process().uid() != peer->process().euid())) // Disallow tracing setuid processes
|
||||
return KResult(-EACCES);
|
||||
|
||||
auto& peer_process = peer->process();
|
||||
if (params.request == PT_ATTACH) {
|
||||
if (peer->tracer()) {
|
||||
if (peer_process.tracer()) {
|
||||
return KResult(-EBUSY);
|
||||
}
|
||||
peer->start_tracing_from(caller.pid());
|
||||
peer_process.start_tracing_from(caller.pid());
|
||||
ScopedSpinLock lock(peer->get_lock());
|
||||
if (peer->state() != Thread::State::Stopped) {
|
||||
peer->send_signal(SIGSTOP, &caller);
|
||||
|
@ -71,7 +72,7 @@ KResultOr<u32> handle_syscall(const Kernel::Syscall::SC_ptrace_params& params, P
|
|||
return KSuccess;
|
||||
}
|
||||
|
||||
auto* tracer = peer->tracer();
|
||||
auto* tracer = peer_process.tracer();
|
||||
|
||||
if (!tracer)
|
||||
return KResult(-EPERM);
|
||||
|
@ -88,7 +89,7 @@ KResultOr<u32> handle_syscall(const Kernel::Syscall::SC_ptrace_params& params, P
|
|||
break;
|
||||
|
||||
case PT_DETACH:
|
||||
peer->stop_tracing();
|
||||
peer_process.stop_tracing();
|
||||
peer->send_signal(SIGCONT, &caller);
|
||||
break;
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue