RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 20:28:11 +00:00
Code Issues Activity Actions

LibWeb: Use Document::m_type to check for XML documents

Browse source 
...instead of doing a string compare on the DOCTYPE node.
This commit is contained in:
Andreas Kling 2022-08-05 01:05:35 +02:00
parent 99ecc216d7
commit c46a8194b4
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -377,7 +377,7 @@ ExceptionOr<void> Document::writeln(Vector<String> const& strings)
ExceptionOr<void> Document::run_the_document_write_steps(String input)
{
// 1. If document is an XML document, then throw an "InvalidStateError" DOMException.
if (doctype() && doctype()->name() == "xml")
if (m_type == Type::XML)
return DOM::InvalidStateError::create("write() called on XML document.");
// 2. If document's throw-on-dynamic-markup-insertion counter is greater than 0, then throw an "InvalidStateError" DOMException.
@ -412,7 +412,7 @@ ExceptionOr<void> Document::run_the_document_write_steps(String input)
ExceptionOr<Document*> Document::open(String const&, String const&)
{
// 1. If document is an XML document, then throw an "InvalidStateError" DOMException exception.
if (doctype() && doctype()->name() == "xml")
if (m_type == Type::XML)
return DOM::InvalidStateError::create("open() called on XML document.");
// 2. If document's throw-on-dynamic-markup-insertion counter is greater than 0, then throw an "InvalidStateError" DOMException.
@ -482,7 +482,7 @@ ExceptionOr<Document*> Document::open(String const&, String const&)
ExceptionOr<void> Document::close()
{
// 1. If document is an XML document, then throw an "InvalidStateError" DOMException exception.
if (doctype() && doctype()->name() == "xml")
if (m_type == Type::XML)
return DOM::InvalidStateError::create("close() called on XML document.");
// 2. If document's throw-on-dynamic-markup-insertion counter is greater than 0, then throw an "InvalidStateError" DOMException.