RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:37:46 +00:00
Code Issues Activity Actions

LibWasm: Limit module memory to 65536 pages

Browse source 
The spec mentions this, and anything past that can't be correctly
addressed by the 32-bit indices anyhow.
This commit is contained in:
Ali Mohammad Pur 2021-07-06 14:03:54 +04:30 • committed by Ali Mohammad Pur
parent 03fe50d5e7
commit c4d4c657d0
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibWasm/AbstractMachine/AbstractMachine.h
View file

@ -350,6 +350,9 @@ public:
if (size_to_grow == 0) if (size_to_grow == 0)
return true; return true;
auto new_size = m_data.size() + size_to_grow; auto new_size = m_data.size() + size_to_grow;
// Can't grow past 2^16 pages.
if (new_size >= Constants::page_size * 65536)
return false;
if (auto max = m_type.limits().max(); max.has_value()) { if (auto max = m_type.limits().max(); max.has_value()) {
if (max.value() * Constants::page_size < new_size) if (max.value() * Constants::page_size < new_size)
return false; return false;