From c4d75ac11ad372375b8478db6b84ea2ad4423313 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Fri, 5 Jan 2024 11:08:12 +0100 Subject: [PATCH] LibGfx/GIF: Avoid a silly loop in GIF logical screen parsing --- Userland/Libraries/LibGfx/ImageFormats/GIFLoader.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Userland/Libraries/LibGfx/ImageFormats/GIFLoader.cpp b/Userland/Libraries/LibGfx/ImageFormats/GIFLoader.cpp index 22dbdf6140..dcd764f85b 100644 --- a/Userland/Libraries/LibGfx/ImageFormats/GIFLoader.cpp +++ b/Userland/Libraries/LibGfx/ImageFormats/GIFLoader.cpp @@ -250,11 +250,9 @@ static ErrorOr load_header_and_logical_screen(GIFLoadingContext& context) if (global_color_table_flag) { u8 bits_per_pixel = (packed_fields & 7) + 1; - int color_map_entry_count = 1; - for (int i = 0; i < bits_per_pixel; ++i) - color_map_entry_count *= 2; + size_t color_map_entry_count = 1 << bits_per_pixel; - for (int i = 0; i < color_map_entry_count; ++i) { + for (size_t i = 0; i < color_map_entry_count; ++i) { u8 r = TRY(context.stream.read_value()); u8 g = TRY(context.stream.read_value()); u8 b = TRY(context.stream.read_value());