1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:57:46 +00:00

Everything: Add -Wnon-virtual-dtor flag

This flag warns on classes which have `virtual` functions but do not
have a `virtual` destructor.

This patch adds both the flag and missing destructors. The access level
of the destructors was determined by a two rules of thumb:
1. A destructor should have a similar or lower access level to that of a
   constructor.
2. Having a `private` destructor implicitly deletes the default
   constructor, which is probably undesirable for "interface" types
   (classes with only virtual functions and no data).

In short, most of the added destructors are `protected`, unless the
compiler complained about access.
This commit is contained in:
Nicholas-Baron 2021-04-15 10:43:29 -07:00 committed by Andreas Kling
parent b75d2d36e1
commit c4ede38542
21 changed files with 57 additions and 0 deletions

View file

@ -93,6 +93,8 @@ public:
virtual Value count_reset() = 0;
protected:
virtual ~ConsoleClient() = default;
VM& vm();
GlobalObject& global_object() { return m_console.global_object(); }

View file

@ -58,6 +58,7 @@ public:
protected:
virtual void visit_impl(Cell*) = 0;
virtual ~Visitor() = default;
};
virtual void visit_edges(Visitor&) { }