RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:27:35 +00:00
Code Issues Activity Actions

LibWeb: Fix division by zero in solve_replaced_size_constraint()

Browse source 
Fixes crashes that occur in Discord after clicking on a direct messages
conversation.
This commit is contained in:
Aliaksandr Kalenik 2024-02-20 19:11:42 +01:00 • committed by Andreas Kling
parent 3ac4b02604
commit c4f49e343a
3 changed files with 31 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Tests/LibWeb/Layout/expected/zero-size-replaced-box-with-aspect-ratio.txt Normal file
View file

@ -0,0 +1,13 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x16 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x0 children: not-inline
BlockContainer <div> at (8,8) content-size 0x0 children: inline
frag 0 from SVGSVGBox start: 0, length: 0, rect: [8,8 100x100] baseline: 100
SVGSVGBox <svg> at (8,8) content-size 100x100 [SVG] children: not-inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x16] overflow: [0,0 800x108]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x0] overflow: [8,8 100x100]
PaintableWithLines (BlockContainer<DIV>) [8,8 0x0] overflow: [8,8 100x100]
SVGSVGPaintable (SVGSVGBox<svg>) [8,8 100x100]

8
Tests/LibWeb/Layout/input/zero-size-replaced-box-with-aspect-ratio.html Normal file
View file

@ -0,0 +1,8 @@
<!DOCTYPE html>
<style>
svg {
aspect-ratio: 1 / 1;
min-width: 100px;
min-height: 100px;
}
</style><div style="width: 0px; height: 0px"><svg xmlns="http://www.w3.org/2000/svg"></svg>