RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 15:42:44 +00:00
Code Issues Activity Actions

LibWeb: Allow event handler attributes on HTMLLinkElement

Browse source 
We were neglecting to set up event handlers for these due to a missing
call to the base class in HTMLLinkElement::parse_attribute().
This commit is contained in:
Andreas Kling 2023-06-06 07:07:27 +02:00
parent b97004ea4a
commit c50ce2030d
3 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/link-element-onload-attribute.txt Normal file
View file

@ -0,0 +1 @@
link element onload

9
Tests/LibWeb/Text/input/link-element-onload-attribute.html Normal file
View file

@ -0,0 +1,9 @@
<script src="include.js"></script>
<script>
let link = document.createElement("link");
link.setAttribute("rel", "preload");
link.setAttribute("href", "valid.css");
link.setAttribute("as", "style");
link.setAttribute("onload", "println('link element onload')");
document.head.appendChild(link);
</script>

2
Userland/Libraries/LibWeb/HTML/HTMLLinkElement.cpp
View file

@ -79,6 +79,8 @@ bool HTMLLinkElement::has_loaded_icon() const
void HTMLLinkElement::parse_attribute(DeprecatedFlyString const& name, DeprecatedString const& value) void HTMLLinkElement::parse_attribute(DeprecatedFlyString const& name, DeprecatedString const& value)
{ {
HTMLElement::parse_attribute(name, value);
// 4.6.7 Link types - https://html.spec.whatwg.org/multipage/links.html#linkTypes // 4.6.7 Link types - https://html.spec.whatwg.org/multipage/links.html#linkTypes
if (name == HTML::AttributeNames::rel) { if (name == HTML::AttributeNames::rel) {
m_relationship = 0; m_relationship = 0;