RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:47:44 +00:00
Code Issues Activity Actions

LibJS: Make call_native_property_{g,s}etter() take a NativeProperty&

Browse source 
Passing in a plain Value and expecting it to be a native property is
error prone, let's use a more narrow type and pass a NativeProperty
reference directly.
This commit is contained in:
Linus Groh 2020-11-22 17:04:40 +00:00 • committed by Andreas Kling
parent 773df8826d
commit c52739ea4b
2 changed files with 13 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibJS/Runtime/Object.h
View file

@ -167,8 +167,8 @@ private:
bool put_own_property(Object& this_object, const StringOrSymbol& property_name, Value, PropertyAttributes attributes, PutOwnPropertyMode = PutOwnPropertyMode::Put, bool throw_exceptions = true);
bool put_own_property_by_index(Object& this_object, u32 property_index, Value, PropertyAttributes attributes, PutOwnPropertyMode = PutOwnPropertyMode::Put, bool throw_exceptions = true);
Value call_native_property_getter(Object* this_object, Value property) const;
void call_native_property_setter(Object* this_object, Value property, Value) const;
Value call_native_property_getter(Object* this_object, NativeProperty& property) const;
void call_native_property_setter(Object* this_object, NativeProperty& property, Value) const;
void set_shape(Shape&);