From c52d3e65b90a166741ca5e1fb6c9cb36b5db305a Mon Sep 17 00:00:00 2001 From: Itamar Date: Thu, 9 Apr 2020 18:59:53 +0300 Subject: [PATCH] LibCrypto: Cleanup UnsignedBigInteger a bit - Add missing 'explicit' to the constructor - Remove unneeded 'AK::' in AK::Vector - Avoid copying 'words' in constructor --- Libraries/LibCrypto/BigInt/UnsignedBigInteger.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Libraries/LibCrypto/BigInt/UnsignedBigInteger.h b/Libraries/LibCrypto/BigInt/UnsignedBigInteger.h index dae419c9e6..660b234583 100644 --- a/Libraries/LibCrypto/BigInt/UnsignedBigInteger.h +++ b/Libraries/LibCrypto/BigInt/UnsignedBigInteger.h @@ -38,12 +38,12 @@ class UnsignedBigInteger { public: UnsignedBigInteger(u32 x) { m_words.append(x); } - UnsignedBigInteger(AK::Vector&& words) - : m_words(words) + explicit UnsignedBigInteger(AK::Vector&& words) + : m_words(move(words)) { } - UnsignedBigInteger() {} + UnsignedBigInteger() { } static UnsignedBigInteger from_base10(const String& str); static UnsignedBigInteger create_invalid();