RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:57:35 +00:00
Code Issues Activity Actions

LibJS: Make AbstractOperations::canonical_num... take a PropertyName

Browse source 
This allows us to hide the fact that it could be a number and means we
no longer need to check for this optimization in string and typedarray
This commit is contained in:
davidot 2021-07-05 01:55:45 +02:00 • committed by Linus Groh
parent 9b7e48c6bd
commit c52d515028
4 changed files with 31 additions and 64 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibJS/Runtime/AbstractOperations.cpp
View file

@ -544,10 +544,19 @@ Object* create_mapped_arguments_object(GlobalObject& global_object, FunctionObje
}
// 7.1.21 CanonicalNumericIndexString ( argument ), https://tc39.es/ecma262/#sec-canonicalnumericindexstring
Value canonical_numeric_index_string(GlobalObject& global_object, Value argument)
Value canonical_numeric_index_string(GlobalObject& global_object, PropertyName const& property_name)
{
// NOTE: If the property name is a number type (An implementation-defined optimized
// property key type), it can be treated as a string property that has already been
// converted successfully into a canonical numeric index.
VERIFY(property_name.is_string() || property_name.is_number());
if (property_name.is_number())
return Value(property_name.as_number());
// 1. Assert: Type(argument) is String.
VERIFY(argument.is_string());
auto argument = Value(js_string(global_object.vm(), property_name.as_string()));
// 2. If argument is "-0", return -0𝔽.
if (argument.as_string().string() == "-0")