RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 09:58:11 +00:00
Code Issues Activity Actions

LibJS: Use IntrusiveList for Allocator's block lists

Browse source 
This way we don't need to deal with shifting vector storage, and most
operations are upgraded from O(n) to O(1) :^)
This commit is contained in:
Andreas Kling 2020-10-07 14:04:52 +02:00
parent eeffd5be07
commit c541310e19
3 changed files with 17 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Libraries/LibJS/Heap/Allocator.cpp
View file

@ -42,35 +42,28 @@ Allocator::~Allocator()
Cell* Allocator::allocate_cell(Heap& heap)
{
if (m_usable_blocks.is_empty()) {
m_usable_blocks.append(HeapBlock::create_with_cell_size(heap, m_cell_size));
auto block = HeapBlock::create_with_cell_size(heap, m_cell_size);
m_usable_blocks.append(*block.leak_ptr());
}
auto& block = *m_usable_blocks.last();
auto* cell = block.allocate();
ASSERT(cell);
if (block.is_full()) {
m_full_blocks.append(m_usable_blocks.take_last());
}
if (block.is_full())
m_full_blocks.append(*m_usable_blocks.last());
return cell;
}
void Allocator::block_did_become_empty(Badge<Heap>, HeapBlock& block)
{
bool removed_something = false;
removed_something |= m_full_blocks.remove_first_matching([&block](auto& entry) { return entry == &block; });
removed_something |= m_usable_blocks.remove_first_matching([&block](auto& entry) { return entry == &block; });
ASSERT(removed_something);
block.m_list_node.remove();
delete &block;
}
void Allocator::block_did_become_usable(Badge<Heap>, HeapBlock& block)
{
ASSERT(!block.is_full());
auto it = m_full_blocks.find([&](auto& entry) {
return entry == &block;
});
ASSERT(it != m_full_blocks.end());
auto owned_block = m_full_blocks.take(it.index());
m_usable_blocks.append(move(owned_block));
m_usable_blocks.append(block);
}
}