RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 06:57:46 +00:00
Code Issues Activity Actions

LibJS: Use IntrusiveList for Allocator's block lists

Browse source 
This way we don't need to deal with shifting vector storage, and most
operations are upgraded from O(n) to O(1) :^)
This commit is contained in:
Andreas Kling 2020-10-07 14:04:52 +02:00
parent eeffd5be07
commit c541310e19
3 changed files with 17 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Libraries/LibJS/Heap/Allocator.h
View file

@ -26,9 +26,11 @@
#pragma once
#include <AK/IntrusiveList.h>
#include <AK/NonnullOwnPtr.h>
#include <AK/Vector.h>
#include <LibJS/Forward.h>
#include <LibJS/Heap/HeapBlock.h>
namespace JS {
@ -45,11 +47,11 @@ public:
IterationDecision for_each_block(Callback callback)
{
for (auto& block : m_full_blocks) {
if (callback(*block) == IterationDecision::Break)
if (callback(block) == IterationDecision::Break)
return IterationDecision::Break;
}
for (auto& block : m_usable_blocks) {
if (callback(*block) == IterationDecision::Break)
if (callback(block) == IterationDecision::Break)
return IterationDecision::Break;
}
return IterationDecision::Continue;
@ -61,8 +63,9 @@ public:
private:
const size_t m_cell_size;
Vector<NonnullOwnPtr<HeapBlock>> m_full_blocks;
Vector<NonnullOwnPtr<HeapBlock>> m_usable_blocks;
typedef IntrusiveList<HeapBlock, &HeapBlock::m_list_node> BlockList;
BlockList m_full_blocks;
BlockList m_usable_blocks;
};
}