RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 22:27:35 +00:00
Code Issues Activity Actions

Tests: Fix AK/TestJSON.cpp by not relying on disk resources

Browse source 
The following commit broke Tests/AK/TestJSON.cpp as it removed the
file that the test loaded from disk to validate JSON parsing.

    commit ad141a2286
    Author: Andreas Kling <kling@serenityos.org>
    Date:   Sat Jul 31 15:26:14 2021 +0200

        Base: Remove "test.frm" from HackStudio test project

Instead of restoring the file, lets just embed a bit of JSON in the
test case to avoid using external resources, as they obviously are
surprising and make the test less portable across environments.
This commit is contained in:
Brian Gianforcaro 2021-07-31 14:13:38 -07:00 • committed by Gunnar Beutner
parent 05faca91d5
commit c54ae3afd6
3 changed files with 22 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Tests/AK/CMakeLists.txt
View file

@ -71,6 +71,3 @@ set(AK_TEST_SOURCES
foreach(source ${AK_TEST_SOURCES})
serenity_test(${source} AK)
endforeach()
get_filename_component(TEST_FRM_RESOLVED ./test.frm REALPATH)
install(FILES ${TEST_FRM_RESOLVED} DESTINATION usr/Tests/AK)