From c569c88e6357ee447bfab316ef35744f064e4efe Mon Sep 17 00:00:00 2001
From: Andreas Kling <kling@serenityos.org>
Date: Thu, 1 Sep 2022 12:14:28 +0200
Subject: [PATCH] LibWeb: Don't have Handle<Realm> in
 WindowEnvironmentSettingsObject

This was preventing window realms from ever being garbage collected.
---
 .../LibWeb/HTML/Scripting/WindowEnvironmentSettingsObject.cpp   | 2 +-
 .../LibWeb/HTML/Scripting/WindowEnvironmentSettingsObject.h     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Userland/Libraries/LibWeb/HTML/Scripting/WindowEnvironmentSettingsObject.cpp b/Userland/Libraries/LibWeb/HTML/Scripting/WindowEnvironmentSettingsObject.cpp
index b38b9c409e..2d3befe376 100644
--- a/Userland/Libraries/LibWeb/HTML/Scripting/WindowEnvironmentSettingsObject.cpp
+++ b/Userland/Libraries/LibWeb/HTML/Scripting/WindowEnvironmentSettingsObject.cpp
@@ -12,7 +12,7 @@ namespace Web::HTML {
 
 WindowEnvironmentSettingsObject::WindowEnvironmentSettingsObject(Window& window, NonnullOwnPtr<JS::ExecutionContext> execution_context)
     : EnvironmentSettingsObject(move(execution_context))
-    , m_window(JS::make_handle(window))
+    , m_window(window)
 {
 }
 
diff --git a/Userland/Libraries/LibWeb/HTML/Scripting/WindowEnvironmentSettingsObject.h b/Userland/Libraries/LibWeb/HTML/Scripting/WindowEnvironmentSettingsObject.h
index d14300b84c..d513ff3efd 100644
--- a/Userland/Libraries/LibWeb/HTML/Scripting/WindowEnvironmentSettingsObject.h
+++ b/Userland/Libraries/LibWeb/HTML/Scripting/WindowEnvironmentSettingsObject.h
@@ -26,7 +26,7 @@ public:
 private:
     WindowEnvironmentSettingsObject(Window&, NonnullOwnPtr<JS::ExecutionContext>);
 
-    JS::Handle<Window> m_window;
+    WeakPtr<Window> m_window;
 };
 
 }