RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 17:34:59 +00:00
Code Issues Activity Actions

LibWeb: Use inline script tag source line as javascript line offset

Browse source 
This makes JS exception line numbers meaningful for inline script tags.
This commit is contained in:
Idan Horowitz 2022-03-13 23:17:35 +02:00 • committed by Andreas Kling
parent 47d0d9fd65
commit c575710e5e
7 changed files with 12 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibWeb/HTML/Parser/HTMLParser.cpp
View file

@ -790,6 +790,7 @@ void HTMLParser::handle_in_head(HTMLToken& token)
auto& script_element = verify_cast<HTMLScriptElement>(*element);
script_element.set_parser_document({}, document());
script_element.set_non_blocking({}, false);
script_element.set_source_line_number({}, token.start_position().line + 1); // FIXME: This +1 is incorrect for script tags whose script does not start on a new line
if (m_parsing_fragment) {
script_element.set_already_started({}, true);