RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 05:24:58 +00:00
Code Issues Activity Actions

LibPDF: Add a FIXME and a spec comment to Encoding::from_object()

Browse source
This commit is contained in:
Nico Weber 2024-01-03 19:47:16 -05:00 • committed by Andreas Kling
parent ad5fc0eda1
commit c59e08123b
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibPDF/Encoding.cpp
View file

@ -42,6 +42,11 @@ PDFErrorOr<NonnullRefPtr<Encoding>> Encoding::from_object(Document* document, No
auto base_encoding_obj = MUST(dict->get_object(document, CommonNames::BaseEncoding));
base_encoding = TRY(Encoding::from_object(document, base_encoding_obj));
} else {
// FIXME:
// "If this entry is absent, the Differences entry describes differences from an implicit base encoding.
// For a font program that is embedded in the PDF file, the implicit base encoding is the font program’s built-in encoding,
// as described above and further elaborated in the sections on specific font types below.
// Otherwise, for a nonsymbolic font, it is StandardEncoding, and for a symbolic font, it is the font’s built-in encoding."
base_encoding = Encoding::standard_encoding();
}