diff --git a/Userland/Libraries/LibDebug/Dwarf/AbbreviationsMap.cpp b/Userland/Libraries/LibDebug/Dwarf/AbbreviationsMap.cpp index ed5ad5ad03..5cd2e4f4b3 100644 --- a/Userland/Libraries/LibDebug/Dwarf/AbbreviationsMap.cpp +++ b/Userland/Libraries/LibDebug/Dwarf/AbbreviationsMap.cpp @@ -66,9 +66,13 @@ void AbbreviationsMap::populate_map() } } -Optional AbbreviationsMap::get(u32 code) const +AbbreviationsMap::AbbreviationEntry const* AbbreviationsMap::get(u32 code) const { - return m_entries.get(code); + auto it = m_entries.find(code); + if (it == m_entries.end()) { + return nullptr; + } + return &it->value; } } diff --git a/Userland/Libraries/LibDebug/Dwarf/AbbreviationsMap.h b/Userland/Libraries/LibDebug/Dwarf/AbbreviationsMap.h index f1a5459c73..9b5cb74334 100644 --- a/Userland/Libraries/LibDebug/Dwarf/AbbreviationsMap.h +++ b/Userland/Libraries/LibDebug/Dwarf/AbbreviationsMap.h @@ -20,14 +20,12 @@ public: AbbreviationsMap(DwarfInfo const& dwarf_info, u32 offset); struct AbbreviationEntry { - EntryTag tag; bool has_children; Vector attribute_specifications; }; - - Optional get(u32 code) const; + AbbreviationEntry const* get(u32 code) const; private: void populate_map(); diff --git a/Userland/Libraries/LibDebug/Dwarf/DIE.cpp b/Userland/Libraries/LibDebug/Dwarf/DIE.cpp index 1adabbd21c..76af73aa6e 100644 --- a/Userland/Libraries/LibDebug/Dwarf/DIE.cpp +++ b/Userland/Libraries/LibDebug/Dwarf/DIE.cpp @@ -32,13 +32,13 @@ void DIE::rehydrate_from(u32 offset, Optional parent_offset) m_tag = EntryTag::None; } else { auto abbreviation_info = m_compilation_unit.abbreviations_map().get(m_abbreviation_code); - VERIFY(abbreviation_info.has_value()); + VERIFY(abbreviation_info); - m_tag = abbreviation_info.value().tag; - m_has_children = abbreviation_info.value().has_children; + m_tag = abbreviation_info->tag; + m_has_children = abbreviation_info->has_children; // We iterate the attributes data only to calculate this DIE's size - for (auto& attribute_spec : abbreviation_info.value().attribute_specifications) { + for (auto& attribute_spec : abbreviation_info->attribute_specifications) { m_compilation_unit.dwarf_info().get_attribute_value(attribute_spec.form, attribute_spec.value, stream, &m_compilation_unit); } } @@ -52,9 +52,9 @@ Optional DIE::get_attribute(Attribute const& attribute) const stream.discard_or_error(m_data_offset); auto abbreviation_info = m_compilation_unit.abbreviations_map().get(m_abbreviation_code); - VERIFY(abbreviation_info.has_value()); + VERIFY(abbreviation_info); - for (const auto& attribute_spec : abbreviation_info.value().attribute_specifications) { + for (const auto& attribute_spec : abbreviation_info->attribute_specifications) { auto value = m_compilation_unit.dwarf_info().get_attribute_value(attribute_spec.form, attribute_spec.value, stream, &m_compilation_unit); if (attribute_spec.attribute == attribute) { return value;