RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:57:45 +00:00
Code Issues Activity Actions

LibJS: Remove redundant ToString from ToTemporalZonedDateTime

Browse source 
Assert that the type of offsetString is either undefined or
string in order to avoid unnecessary ToString
Temporal commit: tc39/proposal-temporal@24ebcbd
This commit is contained in:
BodilessSleeper 2023-01-14 04:30:51 +01:00 • committed by Linus Groh
parent 219db02b2f
commit c5daa6d997
1 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibJS/Runtime/Temporal/ZonedDateTime.cpp
View file

@ -167,16 +167,14 @@ ThrowCompletionOr<ZonedDateTime*> to_temporal_zoned_date_time(VM& vm, Value item
// i. Let offsetString be ! Get(fields, "offset"). // i. Let offsetString be ! Get(fields, "offset").
auto offset_string_value = MUST(fields->get(vm.names.offset)); auto offset_string_value = MUST(fields->get(vm.names.offset));
// j. If offsetString is undefined, then // j. Assert: offsetString is a String or undefined.
VERIFY(offset_string_value.is_string() || offset_string_value.is_undefined());
// k. If offsetString is undefined, then
if (offset_string_value.is_undefined()) { if (offset_string_value.is_undefined()) {
// i. Set offsetBehaviour to wall. // i. Set offsetBehaviour to wall.
offset_behavior = OffsetBehavior::Wall; offset_behavior = OffsetBehavior::Wall;
} }
// k. Else,
else {
// i. Set offsetString to ? ToString(offsetString).
offset_string = TRY(offset_string_value.to_deprecated_string(vm));
}
// l. Let result be ? InterpretTemporalDateTimeFields(calendar, fields, options). // l. Let result be ? InterpretTemporalDateTimeFields(calendar, fields, options).
result = TRY(interpret_temporal_date_time_fields(vm, *calendar, *fields, *options)); result = TRY(interpret_temporal_date_time_fields(vm, *calendar, *fields, *options));