RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-21 11:15:07 +00:00
Code Issues Activity Actions

LibGUI: Fix crash when trying to scroll above the head of the document

Browse source 
We can't go higher than line 0. Can't rely on max() here since line
numbers are unsigned.

Fixes #1145.
This commit is contained in:
Andreas Kling 2020-01-27 22:58:50 +01:00
parent 169a38113e
commit c5db596c78
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibGUI/GTextEditor.cpp
View file

@ -650,7 +650,8 @@ void GTextEditor::keydown_event(GKeyEvent& event)
}
if (event.key() == KeyCode::Key_PageUp) {
if (m_cursor.line() > 0) {
size_t new_line = max((size_t)0, m_cursor.line() - (size_t)visible_content_rect().height() / (size_t)line_height());
size_t page_step = (size_t)visible_content_rect().height() / (size_t)line_height();
size_t new_line = m_cursor.line() < page_step ? 0 : m_cursor.line() - page_step;
size_t new_column = min(m_cursor.column(), line(new_line).length());
toggle_selection_if_needed_for_event(event);
set_cursor(new_line, new_column);