RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:57:45 +00:00
Code Issues Activity Actions

Profiler: Avoid copies / String construction when parsing profile (#7096)

Browse source 
Use sv literal suffix to construct StringViews at compile time,
and make sure to reference array items by const reference.
This commit is contained in:
Brian Gianforcaro 2021-05-14 08:21:25 +00:00 • committed by GitHub
parent 5a7db74c52
commit c63761a341
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

32
Userland/DevTools/Profiler/Profile.cpp
View file

@ -79,9 +79,9 @@ void Profile::rebuild_tree()
HashTable<FlatPtr> live_allocations; HashTable<FlatPtr> live_allocations;
for_each_event_in_filter_range([&](auto& event) { for_each_event_in_filter_range([&](auto& event) {
if (event.type == "malloc") if (event.type == "malloc"sv)
live_allocations.set(event.ptr); live_allocations.set(event.ptr);
else if (event.type == "free") else if (event.type == "free"sv)
live_allocations.remove(event.ptr); live_allocations.remove(event.ptr);
}); });
@ -100,17 +100,17 @@ void Profile::rebuild_tree()
continue; continue;
if (!m_show_scheduler && !event.frames.is_empty()) { if (!m_show_scheduler && !event.frames.is_empty()) {
auto top_frame = event.frames[event.frames.size() - 1]; const auto& top_frame = event.frames[event.frames.size() - 1];
if (top_frame.symbol == "Kernel::Scheduler::yield()") if (top_frame.symbol == "Kernel::Scheduler::yield()"sv)
continue; continue;
} }
m_filtered_event_indices.append(event_index); m_filtered_event_indices.append(event_index);
if (event.type == "malloc" && !live_allocations.contains(event.ptr)) if (event.type == "malloc"sv && !live_allocations.contains(event.ptr))
continue; continue;
if (event.type == "free") if (event.type == "free"sv)
continue; continue;
auto for_each_frame = [&]<typename Callback>(Callback callback) { auto for_each_frame = [&]<typename Callback>(Callback callback) {
@ -233,12 +233,12 @@ Result<NonnullOwnPtr<Profile>, String> Profile::load_from_perfcore_file(const St
event.pid = perf_event.get("pid").to_i32(); event.pid = perf_event.get("pid").to_i32();
event.tid = perf_event.get("tid").to_i32(); event.tid = perf_event.get("tid").to_i32();
if (event.type == "malloc") { if (event.type == "malloc"sv) {
event.ptr = perf_event.get("ptr").to_number<FlatPtr>(); event.ptr = perf_event.get("ptr").to_number<FlatPtr>();
event.size = perf_event.get("size").to_number<size_t>(); event.size = perf_event.get("size").to_number<size_t>();
} else if (event.type == "free") { } else if (event.type == "free"sv) {
event.ptr = perf_event.get("ptr").to_number<FlatPtr>(); event.ptr = perf_event.get("ptr").to_number<FlatPtr>();
} else if (event.type == "mmap") { } else if (event.type == "mmap"sv) {
event.ptr = perf_event.get("ptr").to_number<FlatPtr>(); event.ptr = perf_event.get("ptr").to_number<FlatPtr>();
event.size = perf_event.get("size").to_number<size_t>(); event.size = perf_event.get("size").to_number<size_t>();
event.name = perf_event.get("name").to_string(); event.name = perf_event.get("name").to_string();
@ -247,11 +247,11 @@ Result<NonnullOwnPtr<Profile>, String> Profile::load_from_perfcore_file(const St
if (it != current_processes.end()) if (it != current_processes.end())
it->value->library_metadata.handle_mmap(event.ptr, event.size, event.name); it->value->library_metadata.handle_mmap(event.ptr, event.size, event.name);
continue; continue;
} else if (event.type == "munmap") { } else if (event.type == "munmap"sv) {
event.ptr = perf_event.get("ptr").to_number<FlatPtr>(); event.ptr = perf_event.get("ptr").to_number<FlatPtr>();
event.size = perf_event.get("size").to_number<size_t>(); event.size = perf_event.get("size").to_number<size_t>();
continue; continue;
} else if (event.type == "process_create") { } else if (event.type == "process_create"sv) {
event.parent_pid = perf_event.get("parent_pid").to_number<FlatPtr>(); event.parent_pid = perf_event.get("parent_pid").to_number<FlatPtr>();
event.executable = perf_event.get("executable").to_string(); event.executable = perf_event.get("executable").to_string();
@ -264,7 +264,7 @@ Result<NonnullOwnPtr<Profile>, String> Profile::load_from_perfcore_file(const St
current_processes.set(sampled_process->pid, sampled_process); current_processes.set(sampled_process->pid, sampled_process);
all_processes.append(move(sampled_process)); all_processes.append(move(sampled_process));
continue; continue;
} else if (event.type == "process_exec") { } else if (event.type == "process_exec"sv) {
event.executable = perf_event.get("executable").to_string(); event.executable = perf_event.get("executable").to_string();
auto old_process = current_processes.get(event.pid).value(); auto old_process = current_processes.get(event.pid).value();
@ -280,19 +280,19 @@ Result<NonnullOwnPtr<Profile>, String> Profile::load_from_perfcore_file(const St
current_processes.set(sampled_process->pid, sampled_process); current_processes.set(sampled_process->pid, sampled_process);
all_processes.append(move(sampled_process)); all_processes.append(move(sampled_process));
continue; continue;
} else if (event.type == "process_exit") { } else if (event.type == "process_exit"sv) {
auto old_process = current_processes.get(event.pid).value(); auto old_process = current_processes.get(event.pid).value();
old_process->end_valid = event.timestamp - 1; old_process->end_valid = event.timestamp - 1;
current_processes.remove(event.pid); current_processes.remove(event.pid);
continue; continue;
} else if (event.type == "thread_create") { } else if (event.type == "thread_create"sv) {
event.parent_tid = perf_event.get("parent_tid").to_i32(); event.parent_tid = perf_event.get("parent_tid").to_i32();
auto it = current_processes.find(event.pid); auto it = current_processes.find(event.pid);
if (it != current_processes.end()) if (it != current_processes.end())
it->value->handle_thread_create(event.tid, event.timestamp); it->value->handle_thread_create(event.tid, event.timestamp);
continue; continue;
} else if (event.type == "thread_exit") { } else if (event.type == "thread_exit"sv) {
auto it = current_processes.find(event.pid); auto it = current_processes.find(event.pid);
if (it != current_processes.end()) if (it != current_processes.end())
it->value->handle_thread_exit(event.tid, event.timestamp); it->value->handle_thread_exit(event.tid, event.timestamp);
@ -488,7 +488,7 @@ ProfileNode::ProfileNode(const String& object_name, String symbol, u32 address,
, m_timestamp(timestamp) , m_timestamp(timestamp)
{ {
String object; String object;
if (object_name.ends_with(": .text")) { if (object_name.ends_with(": .text"sv)) {
object = object_name.view().substring_view(0, object_name.length() - 7); object = object_name.view().substring_view(0, object_name.length() - 7);
} else { } else {
object = object_name; object = object_name;

4
Userland/DevTools/Profiler/TimelineTrack.cpp
View file

@ -72,8 +72,8 @@ void TimelineTrack::paint_event(GUI::PaintEvent& event)
continue; continue;
if (!m_profile.show_scheduler() && !event.frames.is_empty()) { if (!m_profile.show_scheduler() && !event.frames.is_empty()) {
auto top_frame = event.frames[event.frames.size() - 1]; const auto& top_frame = event.frames[event.frames.size() - 1];
if (top_frame.symbol == "Kernel::Scheduler::yield()") if (top_frame.symbol == "Kernel::Scheduler::yield()"sv)
continue; continue;
} }