From c66da0f2cb54f552abc7574f873ccb4a9260f4c9 Mon Sep 17 00:00:00 2001 From: Sam Atkins Date: Wed, 13 Apr 2022 20:28:17 +0100 Subject: [PATCH] LibWeb: Assign an underlying type to generated CSS enums I'm *pretty* sure that even a u32 would be overkill but you never know with CSS specs. --- .../CodeGenerators/LibWeb/GenerateCSSEnums.cpp | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateCSSEnums.cpp b/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateCSSEnums.cpp index a9d6aa06aa..bb31170488 100644 --- a/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateCSSEnums.cpp +++ b/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateCSSEnums.cpp @@ -62,7 +62,19 @@ enum class ValueID; enum_generator.set("name:titlecase", title_casify(name)); enum_generator.set("name:snakecase", snake_casify(name)); - enum_generator.appendln("enum class @name:titlecase@ {"); + // Find the smallest possible type to use. + auto member_max_value = members.size() - 1; + if (NumericLimits::max() >= member_max_value) { + enum_generator.set("enum_type", "u8"); + } else if (NumericLimits::max() >= member_max_value) { + enum_generator.set("enum_type", "u16"); + } else if (NumericLimits::max() >= member_max_value) { + enum_generator.set("enum_type", "u32"); + } else { + enum_generator.set("enum_type", "u64"); + } + + enum_generator.appendln("enum class @name:titlecase@ : @enum_type@ {"); for (auto& member : members.values()) { auto member_name = member.to_string();