RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 10:47:44 +00:00
Code Issues Activity Actions

LibJS/JIT: Compile the IteratorClose instruction

Browse source
This commit is contained in:
Simon Wanner 2023-10-29 16:59:53 +01:00 • committed by Andreas Kling
parent 233502a10c
commit c697ff61f6
3 changed files with 28 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibJS/Bytecode/Op.h
View file

@ -1343,6 +1343,9 @@ public:
ThrowCompletionOr<void> execute_impl(Bytecode::Interpreter&) const; ThrowCompletionOr<void> execute_impl(Bytecode::Interpreter&) const;
DeprecatedString to_deprecated_string_impl(Bytecode::Executable const&) const; DeprecatedString to_deprecated_string_impl(Bytecode::Executable const&) const;
Completion::Type completion_type() const { return m_completion_type; }
Optional<Value> const& completion_value() const { return m_completion_value; }
private: private:
Completion::Type m_completion_type { Completion::Type::Normal }; Completion::Type m_completion_type { Completion::Type::Normal };
Optional<Value> m_completion_value; Optional<Value> m_completion_value;

23
Userland/Libraries/LibJS/JIT/Compiler.cpp
View file

@ -1283,6 +1283,29 @@ void Compiler::compile_iterator_result_value(Bytecode::Op::IteratorResultValue c
check_exception(); check_exception();
} }
static Value cxx_iterator_close(VM& vm, Value iterator, Completion::Type completion_type, Optional<Value> const& completion_value)
{
auto iterator_object = TRY_OR_SET_EXCEPTION(iterator.to_object(vm));
auto iterator_record = Bytecode::object_to_iterator(vm, iterator_object);
// FIXME: Return the value of the resulting completion. (Note that m_completion_value can be empty!)
TRY_OR_SET_EXCEPTION(iterator_close(vm, iterator_record, Completion { completion_type, completion_value, {} }));
return {};
}
void Compiler::compile_iterator_close(Bytecode::Op::IteratorClose const& op)
{
load_vm_register(ARG1, Bytecode::Register::accumulator());
m_assembler.mov(
Assembler::Operand::Register(ARG2),
Assembler::Operand::Imm(to_underlying(op.completion_type())));
m_assembler.mov(
Assembler::Operand::Register(ARG3),
Assembler::Operand::Imm(bit_cast<u64>(&op.completion_value())));
native_call((void*)cxx_iterator_close);
check_exception();
}
void Compiler::jump_to_exit() void Compiler::jump_to_exit()
{ {
m_assembler.jump(m_exit_label); m_assembler.jump(m_exit_label);

3
Userland/Libraries/LibJS/JIT/Compiler.h
View file

@ -111,7 +111,8 @@ private:
O(IteratorResultDone, iterator_result_done) \ O(IteratorResultDone, iterator_result_done) \
O(ThrowIfNotObject, throw_if_not_object) \ O(ThrowIfNotObject, throw_if_not_object) \
O(ThrowIfNullish, throw_if_nullish) \ O(ThrowIfNullish, throw_if_nullish) \
O(IteratorResultValue, iterator_result_value) O(IteratorResultValue, iterator_result_value) \
O(IteratorClose, iterator_close)
# define DECLARE_COMPILE_OP(OpTitleCase, op_snake_case) \ # define DECLARE_COMPILE_OP(OpTitleCase, op_snake_case) \
void compile_##op_snake_case(Bytecode::Op::OpTitleCase const&); void compile_##op_snake_case(Bytecode::Op::OpTitleCase const&);