RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:08:11 +00:00
Code Issues Activity Actions

LibJS: Add side-effect-free version of Value::to_string()

Browse source 
There are now two API's on Value:

- Value::to_string(Interpreter&) -- may throw.
- Value::to_string_without_side_effects() -- will never throw.

These are some pretty big sweeping changes, so it's possible that I did
some part the wrong way. We'll work it out as we go. :^)

Fixes #2123.
This commit is contained in:
Andreas Kling 2020-05-15 13:39:24 +02:00
parent d8aa2a6997
commit c6ddbd1f3e
25 changed files with 285 additions and 112 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Libraries/LibWeb/Bindings/WindowObject.cpp
View file

@ -98,8 +98,11 @@ JS::Value WindowObject::alert(JS::Interpreter& interpreter)
if (!impl)
return {};
String message = "";
if (interpreter.argument_count())
message = interpreter.argument(0).to_string();
if (interpreter.argument_count()) {
message = interpreter.argument(0).to_string(interpreter);
if (interpreter.exception())
return {};
}
impl->alert(message);
return JS::js_undefined();
}
@ -110,8 +113,11 @@ JS::Value WindowObject::confirm(JS::Interpreter& interpreter)
if (!impl)
return {};
String message = "";
if (interpreter.argument_count())
message = interpreter.argument(0).to_string();
if (interpreter.argument_count()) {
message = interpreter.argument(0).to_string(interpreter);
if (interpreter.exception())
return {};
}
return JS::Value(impl->confirm(message));
}