RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:37:35 +00:00
Code Issues Activity Actions

LibGUI+WindowServer: Remove now-obsolete cursor tracking feature

Browse source 
This feature was problematic for several reasons:
- Tracking *all* the user activity seems like a privacy nightmare.
- LibGUI actually only supports one globally tracking widget per window,
  even if no window is necessary, or if multiple callbacks are desired.
- Widgets can easily get confused whether an event is actually directed
  at it, or is actually just the result of global tracking.

The third item caused an issue where right-clicking CatDog opened two
context menus instead of one.
This commit is contained in:
Ben Wiederhake 2021-09-07 22:27:18 +02:00 • committed by Andreas Kling
parent 0a69da08aa
commit c6e56612f5
8 changed files with 1 additions and 60 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Services/WindowServer/ClientConnection.cpp
View file

@ -653,16 +653,6 @@ void ClientConnection::set_window_backing_store(i32 window_id, [[maybe_unused]]
window.invalidate(false);
}
void ClientConnection::set_global_cursor_tracking(i32 window_id, bool enabled)
{
auto it = m_windows.find(window_id);
if (it == m_windows.end()) {
did_misbehave("SetGlobalCursorTracking: Bad window ID");
return;
}
it->value->set_global_cursor_tracking_enabled(enabled);
}
void ClientConnection::set_global_mouse_tracking(bool enabled)
{
m_does_global_mouse_tracking = enabled;