RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:57:35 +00:00
Code Issues Activity Actions

LibJS: Follow the spec more closely when determining the this value

Browse source 
Co-authored-by: davidot <david.tuin@gmail.com>
This commit is contained in:
Timothy Flynn 2021-07-12 01:37:51 +02:00 • committed by Andreas Kling
parent a394aa5830
commit c6e9c6d6ab
3 changed files with 36 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibJS/AST.cpp
View file

@ -161,12 +161,8 @@ CallExpression::ThisAndCallee CallExpression::compute_this_and_callee(Interprete
return { this_value, callee };
}
if (interpreter.vm().in_strict_mode()) {
// If we are in strict mode, |this| should never be bound to global object by default.
return { js_undefined(), m_callee->execute(interpreter, global_object) };
}
return { &global_object, m_callee->execute(interpreter, global_object) };
// [[Call]] will handle that in non-strict mode the this value becomes the global object
return { js_undefined(), m_callee->execute(interpreter, global_object) };
}
// 13.3.8.1 Runtime Semantics: ArgumentListEvaluation, https://tc39.es/ecma262/#sec-runtime-semantics-argumentlistevaluation