RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:47:45 +00:00
Code Issues Activity Actions

LibWeb: Honor box-sizing in flex item "specified size suggestion"

Browse source 
Although the spec doesn't mention it, if a flex item has box-sizing:
border-box, and the specified size suggestion is a definite size, we
have to subtract the borders and padding from the size before using it.

This fixes an issue seen in "This Week in Ladybird #4" where the
screenshots ended up in one long vertical stack instead of paired up
2 by 2.
This commit is contained in:
Andreas Kling 2023-04-17 17:31:18 +02:00
parent 7f79208759
commit c710575f88
3 changed files with 30 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Tests/LibWeb/Layout/input/flex/specified-size-suggestion-with-box-sizing-border-box.html Normal file
View file

@ -0,0 +1,21 @@
<!doctype html><style>
* {
margin: 0;
padding: 0;
box-sizing: border-box;
font: 16px SerenitySans;
}
body {
width: 800px;
display: flex;
flex-wrap: wrap;
}
img {
width: 50%;
height: 100px;
background: pink;
}
.padded {
padding-left: 200px;
}
</style><body><img><img class="padded" alt="hello this text is here to make the img have a wide intrinsic size" />