From c713445253c889989101d17cebf166d48c190065 Mon Sep 17 00:00:00 2001 From: timmot Date: Sat, 18 Nov 2023 21:08:25 +1100 Subject: [PATCH] LibWeb: Report when CanvasFillOrStrokeStyle parsing fails --- .../Libraries/LibWeb/HTML/Canvas/CanvasFillStrokeStyles.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibWeb/HTML/Canvas/CanvasFillStrokeStyles.h b/Userland/Libraries/LibWeb/HTML/Canvas/CanvasFillStrokeStyles.h index 84b32cd0e6..44318b7819 100644 --- a/Userland/Libraries/LibWeb/HTML/Canvas/CanvasFillStrokeStyles.h +++ b/Userland/Libraries/LibWeb/HTML/Canvas/CanvasFillStrokeStyles.h @@ -27,7 +27,13 @@ public: { return style.visit( [&](String const& string) -> CanvasState::FillOrStrokeStyle { - return Gfx::Color::from_string(string).value_or(Color::Black); + // FIXME: This should parse color strings the same as CSS + auto color = Gfx::Color::from_string(string); + + if (!color.has_value()) + dbgln_if(CANVAS_RENDERING_CONTEXT_2D_DEBUG, "CanvasFillStrokeStyles: Unsupported canvas fill or stroke style \"{}\". Defaulting to Color::Black.", string); + + return color.value_or(Color::Black); }, [&](auto fill_or_stroke_style) -> CanvasState::FillOrStrokeStyle { return fill_or_stroke_style;