From c713e76941ba1d1bbdf9a59a5888dbdb13fad6de Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Wed, 24 Aug 2022 18:33:15 +0200 Subject: [PATCH] Tests/Kernel: Make sure inaccessible area in TestEFault is actually that We were relying on luck to make the mapping before our first mmap() be inaccessible. Let's make it explicit. --- Tests/Kernel/TestEFault.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Tests/Kernel/TestEFault.cpp b/Tests/Kernel/TestEFault.cpp index 10be1719ec..b1e7f11bab 100644 --- a/Tests/Kernel/TestEFault.cpp +++ b/Tests/Kernel/TestEFault.cpp @@ -41,6 +41,9 @@ TEST_CASE(test_efault) int fd = open("/dev/zero", O_RDONLY); int rc = -1; + // Make an inaccessible hole before the next mapping. + (void)mmap(nullptr, 4096, PROT_NONE, MAP_ANONYMOUS | MAP_PRIVATE, 0, 0); + // Test a one-page mapping (4KB) u8* one_page = (u8*)mmap(nullptr, 4096, PROT_READ | PROT_WRITE, MAP_ANONYMOUS | MAP_PRIVATE, 0, 0); VERIFY(one_page);