RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:57:35 +00:00
Code Issues Activity Actions

LibJS/JIT: Add PutByValue fast path for simple array access

Browse source
This commit is contained in:
iliadsh 2023-11-12 21:14:30 +00:00 • committed by Andreas Kling
parent bbde3cbc90
commit c739c931c1
1 changed files with 121 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

121
Userland/Libraries/LibJS/JIT/Compiler.cpp
View file

@ -1906,6 +1906,126 @@ void Compiler::compile_put_by_value(Bytecode::Op::PutByValue const& op)
{
load_vm_register(ARG1, op.base());
load_vm_register(ARG2, op.property());
Assembler::Label end {};
Assembler::Label slow_case {};
branch_if_object(ARG1, [&] {
branch_if_int32(ARG2, [&] {
// if (ARG2 < 0) goto slow_case;
m_assembler.mov(
Assembler::Operand::Register(GPR0),
Assembler::Operand::Register(ARG2));
m_assembler.sign_extend_32_to_64_bits(GPR0);
m_assembler.jump_if(
Assembler::Operand::Register(GPR0),
Assembler::Condition::SignedLessThan,
Assembler::Operand::Imm(0),
slow_case);
// GPR0 = extract_pointer(ARG1)
extract_object_pointer(GPR0, ARG1);
// if (object->may_interfere_with_indexed_property_access()) goto slow_case;
m_assembler.mov8(
Assembler::Operand::Register(GPR1),
Assembler::Operand::Mem64BaseAndOffset(GPR0, Object::may_interfere_with_indexed_property_access_offset()));
m_assembler.jump_if(
Assembler::Operand::Register(GPR1),
Assembler::Condition::NotEqualTo,
Assembler::Operand::Imm(0),
slow_case);
// GPR0 = object->indexed_properties().storage()
m_assembler.mov(
Assembler::Operand::Register(GPR0),
Assembler::Operand::Mem64BaseAndOffset(GPR0, Object::indexed_properties_offset() + IndexedProperties::storage_offset()));
// if (GPR0 == nullptr) goto slow_case;
m_assembler.jump_if(
Assembler::Operand::Register(GPR0),
Assembler::Condition::EqualTo,
Assembler::Operand::Imm(0),
slow_case);
// if (!GPR0->is_simple_storage()) goto slow_case;
m_assembler.mov8(
Assembler::Operand::Register(GPR1),
Assembler::Operand::Mem64BaseAndOffset(GPR0, IndexedPropertyStorage::is_simple_storage_offset()));
m_assembler.jump_if(
Assembler::Operand::Register(GPR1),
Assembler::Condition::EqualTo,
Assembler::Operand::Imm(0),
slow_case);
// GPR2 = extract_int32(ARG2)
m_assembler.mov32(
Assembler::Operand::Register(GPR2),
Assembler::Operand::Register(ARG2));
// if (GPR2 >= GPR0->array_like_size()) goto slow_case;
m_assembler.mov(
Assembler::Operand::Register(GPR1),
Assembler::Operand::Mem64BaseAndOffset(GPR0, SimpleIndexedPropertyStorage::array_size_offset()));
m_assembler.jump_if(
Assembler::Operand::Register(GPR2),
Assembler::Condition::SignedGreaterThanOrEqualTo,
Assembler::Operand::Register(GPR1),
slow_case);
// GPR0 = GPR0->elements().outline_buffer()
m_assembler.mov(
Assembler::Operand::Register(GPR0),
Assembler::Operand::Mem64BaseAndOffset(GPR0, SimpleIndexedPropertyStorage::elements_offset() + Vector<Value>::outline_buffer_offset()));
// GPR2 *= sizeof(Value)
m_assembler.mul32(
Assembler::Operand::Register(GPR2),
Assembler::Operand::Imm(sizeof(Value)),
slow_case);
// GPR0 = &GRP0[GPR2]
// GPR2 = *GPR0
m_assembler.add(
Assembler::Operand::Register(GPR0),
Assembler::Operand::Register(GPR2));
m_assembler.mov(
Assembler::Operand::Register(GPR2),
Assembler::Operand::Mem64BaseAndOffset(GPR0, 0));
// if (GPR2.is_empty()) goto slow_case;
m_assembler.mov(Assembler::Operand::Register(GPR1), Assembler::Operand::Register(GPR2));
m_assembler.shift_right(Assembler::Operand::Register(GPR1), Assembler::Operand::Imm(TAG_SHIFT));
m_assembler.jump_if(
Assembler::Operand::Register(GPR1),
Assembler::Condition::EqualTo,
Assembler::Operand::Imm(EMPTY_TAG),
slow_case);
// if (GPR2.is_accessor()) goto slow_case;
m_assembler.mov(Assembler::Operand::Register(GPR1), Assembler::Operand::Register(GPR2));
m_assembler.shift_right(Assembler::Operand::Register(GPR1), Assembler::Operand::Imm(TAG_SHIFT));
m_assembler.jump_if(
Assembler::Operand::Register(GPR1),
Assembler::Condition::EqualTo,
Assembler::Operand::Imm(ACCESSOR_TAG),
slow_case);
// GRP1 will clobber ARG3 in X86, so load it later.
load_accumulator(ARG3);
// *GPR0 = value
m_assembler.mov(
Assembler::Operand::Mem64BaseAndOffset(GPR0, 0),
Assembler::Operand::Register(ARG3));
// accumulator = ARG3;
store_accumulator(ARG3);
m_assembler.jump(end);
});
});
slow_case.link(m_assembler);
load_accumulator(ARG3);
m_assembler.mov(
Assembler::Operand::Register(ARG4),
@ -1913,6 +2033,7 @@ void Compiler::compile_put_by_value(Bytecode::Op::PutByValue const& op)
native_call((void*)cxx_put_by_value);
store_accumulator(RET);
check_exception();
end.link(m_assembler);
}
static Value cxx_call(VM& vm, Value callee, u32 first_argument_index, u32 argument_count, Value this_value, Bytecode::Op::CallType call_type, Optional<Bytecode::StringTableIndex> const& expression_string)