RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:27:45 +00:00
Code Issues Activity Actions

WindowServer: Mark screen dirty when changing highlighted window

Browse source 
Because the z-order changes we not only need to recompute occlusions
but we also need to mark the screen area of the previous and new
highlighted window as dirty.

Fixes #5599
This commit is contained in:
Tom 2021-03-02 21:13:42 -07:00 • committed by Andreas Kling
parent 87c1b1a25d
commit c73dfe5bf6
1 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Services/WindowServer/WindowManager.cpp
View file

@ -1252,10 +1252,16 @@ void WindowManager::set_highlight_window(Window* window)
return; return;
auto* previous_highlight_window = m_highlight_window.ptr(); auto* previous_highlight_window = m_highlight_window.ptr();
m_highlight_window = window; m_highlight_window = window;
if (previous_highlight_window) if (previous_highlight_window) {
previous_highlight_window->invalidate(true, true); previous_highlight_window->invalidate(true, true);
if (m_highlight_window) Compositor::the().invalidate_screen(previous_highlight_window->frame().render_rect());
}
if (m_highlight_window) {
m_highlight_window->invalidate(true, true); m_highlight_window->invalidate(true, true);
Compositor::the().invalidate_screen(m_highlight_window->frame().render_rect());
}
// Invalidate occlusions in case the state change changes geometry
Compositor::the().invalidate_occlusions();
} }
bool WindowManager::is_active_window_or_accessory(Window& window) const bool WindowManager::is_active_window_or_accessory(Window& window) const