RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 06:37:43 +00:00
Code Issues Activity Actions

Kernel: Bit mask line control options in SerialDevice::set_line_control

Browse source 
The line control option bits (parity, stop bits, word length) were
masked and then combined incorrectly, resulting in them not being set
when requested.
This commit is contained in:
Idan Horowitz 2021-05-15 01:16:43 +03:00 • committed by Andreas Kling
parent be57c424f3
commit c75ca4ea8f
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/Devices/SerialDevice.cpp
View file

@ -105,7 +105,7 @@ void SerialDevice::set_line_control(ParitySelect parity_select, StopBits stop_bi
m_stop_bits = stop_bits; m_stop_bits = stop_bits;
m_word_length = word_length; m_word_length = word_length;
IO::out8(m_base_addr + 3, IO::in8(m_base_addr + 3) & (0xc0 | parity_select | stop_bits | word_length)); IO::out8(m_base_addr + 3, (IO::in8(m_base_addr + 3) & ~0x3f) | parity_select | stop_bits | word_length);
} }
void SerialDevice::set_break_enable(bool break_enable) void SerialDevice::set_break_enable(bool break_enable)