RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:27:44 +00:00
Code Issues Activity Actions

LibCards+Games: Return ErrorOr from deck-creation factory functions :^)

Browse source 
Also, be smarter about appending cards to the deck: we can
unchecked_append them to the deck, since we already ensured enough
capacity earlier.
This commit is contained in:
Sam Atkins 2023-01-20 13:19:56 +00:00 • committed by Linus Groh
parent 0855e9f014
commit c7c4d70f6e
5 changed files with 15 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Games/Solitaire/Game.cpp
View file

@ -168,7 +168,7 @@ void Game::setup(Mode mode)
if (on_undo_availability_change)
on_undo_availability_change(false);
m_new_deck = Cards::create_standard_deck(Cards::Shuffle::Yes);
m_new_deck = Cards::create_standard_deck(Cards::Shuffle::Yes).release_value_but_fixme_should_propagate_errors();
clear_moving_cards();