mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 09:52:44 +00:00 
			
		
		
		
	LibWeb: Reorganize layout algorithm
Previously, layout recursively performed these steps (roughly): 1. Compute own width 2. Compute own position 3. Layout in-flow children 4. Compute own height 5. Layout absolutely positioned descendants However, step (2) was pretty inconsistent. Some things computed their own position, others had their parent do it for them, etc. To get closer to CSS spec language, and make things easier in general, this patch reorganizes the algorithm into: 1. Compute own width & height 2. Compute width & height of in-flow managed descendants 3. Move in-flow managed descendants to their final position 4. Layout absolutely positioned descendants Block layout is now driven by the containing block, which will iterate the descendants it's responsible for. There are a lot of inefficient patterns in this logic right now, but they can easily be replaced with better iteration functions once we settle on a long-term architecture. Since the ICB (LayoutDocument) is at (0, 0), it doesn't rely on a containing block to move it into place. This code is still evolving along with my understanding of CSS layout, so it's likely that we'll reorganize this again sooner or later. :^)
This commit is contained in:
		
							parent
							
								
									2b47ba6c3f
								
							
						
					
					
						commit
						c7d9229a0f
					
				
					 8 changed files with 144 additions and 162 deletions
				
			
		|  | @ -57,9 +57,6 @@ void LayoutTableRowGroup::layout(LayoutMode) | |||
| { | ||||
|     compute_width(); | ||||
| 
 | ||||
|     if (!is_inline()) | ||||
|         compute_position(); | ||||
| 
 | ||||
|     auto column_count = this->column_count(); | ||||
|     Vector<float> column_widths; | ||||
|     column_widths.resize(column_count); | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue
	
	 Andreas Kling
						Andreas Kling