1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 12:28:12 +00:00

LibJS+LibWeb: Implement resizable ArrayBuffer support for DataView

This is (part of) a normative change in the ECMA-262 spec. See:
a9ae96e
This commit is contained in:
Timothy Flynn 2023-10-15 09:46:09 -04:00 committed by Andreas Kling
parent 29ac6e3689
commit c7fec9424c
12 changed files with 377 additions and 94 deletions

View file

@ -10,15 +10,15 @@ namespace JS {
JS_DEFINE_ALLOCATOR(DataView);
NonnullGCPtr<DataView> DataView::create(Realm& realm, ArrayBuffer* viewed_buffer, size_t byte_length, size_t byte_offset)
NonnullGCPtr<DataView> DataView::create(Realm& realm, ArrayBuffer* viewed_buffer, ByteLength byte_length, size_t byte_offset)
{
return realm.heap().allocate<DataView>(realm, viewed_buffer, byte_length, byte_offset, realm.intrinsics().data_view_prototype());
return realm.heap().allocate<DataView>(realm, viewed_buffer, move(byte_length), byte_offset, realm.intrinsics().data_view_prototype());
}
DataView::DataView(ArrayBuffer* viewed_buffer, size_t byte_length, size_t byte_offset, Object& prototype)
DataView::DataView(ArrayBuffer* viewed_buffer, ByteLength byte_length, size_t byte_offset, Object& prototype)
: Object(ConstructWithPrototypeTag::Tag, prototype)
, m_viewed_array_buffer(viewed_buffer)
, m_byte_length(byte_length)
, m_byte_length(move(byte_length))
, m_byte_offset(byte_offset)
{
}
@ -29,4 +29,96 @@ void DataView::visit_edges(Visitor& visitor)
visitor.visit(m_viewed_array_buffer);
}
// 25.3.1.2 MakeDataViewWithBufferWitnessRecord ( obj, order ), https://tc39.es/ecma262/#sec-makedataviewwithbufferwitnessrecord
DataViewWithBufferWitness make_data_view_with_buffer_witness_record(DataView const& data_view, ArrayBuffer::Order order)
{
// 1. Let buffer be obj.[[ViewedArrayBuffer]].
auto* buffer = data_view.viewed_array_buffer();
ByteLength byte_length { 0 };
// 2. If IsDetachedBuffer(buffer) is true, then
if (buffer->is_detached()) {
// a. Let byteLength be detached.
byte_length = ByteLength::detached();
}
// 3. Else,
else {
// a. Let byteLength be ArrayBufferByteLength(buffer, order).
byte_length = array_buffer_byte_length(*buffer, order);
}
// 4. Return the DataView With Buffer Witness Record { [[Object]]: obj, [[CachedBufferByteLength]]: byteLength }.
return { .object = data_view, .cached_buffer_byte_length = move(byte_length) };
}
// 25.3.1.3 GetViewByteLength ( viewRecord ), https://tc39.es/ecma262/#sec-getviewbytelength
u32 get_view_byte_length(DataViewWithBufferWitness const& view_record)
{
// 1. Assert: IsViewOutOfBounds(viewRecord) is false.
VERIFY(!is_view_out_of_bounds(view_record));
// 2. Let view be viewRecord.[[Object]].
auto const& view = *view_record.object;
// 3. If view.[[ByteLength]] is not auto, return view.[[ByteLength]].
if (!view.byte_length().is_auto())
return view.byte_length().length();
// 4. Assert: IsFixedLengthArrayBuffer(view.[[ViewedArrayBuffer]]) is false.
VERIFY(!view.viewed_array_buffer()->is_fixed_length());
// 5. Let byteOffset be view.[[ByteOffset]].
auto byte_offset = view.byte_offset();
// 6. Let byteLength be viewRecord.[[CachedBufferByteLength]].
auto const& byte_length = view_record.cached_buffer_byte_length;
// 7. Assert: byteLength is not detached.
VERIFY(!byte_length.is_detached());
// 8. Return byteLength - byteOffset.
return byte_length.length() - byte_offset;
}
// 25.3.1.4 IsViewOutOfBounds ( viewRecord ), https://tc39.es/ecma262/#sec-isviewoutofbounds
bool is_view_out_of_bounds(DataViewWithBufferWitness const& view_record)
{
// 1. Let view be viewRecord.[[Object]].
auto const& view = *view_record.object;
// 2. Let bufferByteLength be viewRecord.[[CachedBufferByteLength]].
auto const& buffer_byte_length = view_record.cached_buffer_byte_length;
// 3. Assert: IsDetachedBuffer(view.[[ViewedArrayBuffer]]) is true if and only if bufferByteLength is detached.
VERIFY(view.viewed_array_buffer()->is_detached() == buffer_byte_length.is_detached());
// 4. If bufferByteLength is detached, return true.
if (buffer_byte_length.is_detached())
return true;
// 5. Let byteOffsetStart be view.[[ByteOffset]].
auto byte_offset_start = view.byte_offset();
u32 byte_offset_end = 0;
// 6. If view.[[ByteLength]] is auto, then
if (view.byte_length().is_auto()) {
// a. Let byteOffsetEnd be bufferByteLength.
byte_offset_end = buffer_byte_length.length();
}
// 7. Else,
else {
// a. Let byteOffsetEnd be byteOffsetStart + view.[[ByteLength]].
byte_offset_end = byte_offset_start + view.byte_length().length();
}
// 8. If byteOffsetStart > bufferByteLength or byteOffsetEnd > bufferByteLength, return true.
if ((byte_offset_start > buffer_byte_length.length()) || (byte_offset_end > buffer_byte_length.length()))
return true;
// 9. NOTE: 0-length DataViews are not considered out-of-bounds.
// 10. Return false.
return false;
}
}