RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-16 19:35:08 +00:00
Code Issues Activity Actions

LibGUI: Don't start editing with (just) modifier keys when AnyKeyPressed

Browse source 
This fixes the control key starting an edit on (and inserting a nul
character into) a cell in Spreadsheet.
This commit is contained in:
AnotherTest 2020-11-29 11:05:58 +03:30 • committed by Andreas Kling
parent 474453244b
commit c84756efa8
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibGUI/TableView.cpp
View file

@ -177,11 +177,12 @@ void TableView::keydown_event(KeyEvent& event)
if (event.is_accepted())
return;
if (is_editable() && edit_triggers() & EditTrigger::AnyKeyPressed && !event.text().is_empty()) {
auto is_delete = event.key() == Key_Delete || event.key() == Key_Backspace;
if (is_editable() && edit_triggers() & EditTrigger::AnyKeyPressed && (event.code_point() != 0 || is_delete)) {
begin_editing(cursor_index());
if (m_editing_delegate) {
if (event.key() == KeyCode::Key_Delete || event.key() == KeyCode::Key_Backspace)
m_editing_delegate->set_value(String::empty());
if (is_delete)
m_editing_delegate->set_value(event.key() == Key_Delete ? String {} : String::empty());
else
m_editing_delegate->set_value(event.text());
}