From c857b5d22f7df94ef44a6a75bf1dd54d44491fab Mon Sep 17 00:00:00 2001
From: Simon Woertz <simon@woertz.at>
Date: Sun, 28 Nov 2021 11:52:48 +0100
Subject: [PATCH] LibPDF: Convert `PDF::Parser::m_document` from `RefPtr` to
 `WeakPtr`

Otherwise both `PDF::Document` and `PDF::Parser` have a `RefPtr`
pointing to each other which leads to a memory leak due to a circular
dependency.
---
 Userland/Libraries/LibPDF/Document.h | 5 ++++-
 Userland/Libraries/LibPDF/Parser.cpp | 2 +-
 Userland/Libraries/LibPDF/Parser.h   | 5 +++--
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/Userland/Libraries/LibPDF/Document.h b/Userland/Libraries/LibPDF/Document.h
index 02303cee02..d8da59f2e5 100644
--- a/Userland/Libraries/LibPDF/Document.h
+++ b/Userland/Libraries/LibPDF/Document.h
@@ -9,6 +9,7 @@
 #include <AK/Format.h>
 #include <AK/HashMap.h>
 #include <AK/RefCounted.h>
+#include <AK/Weakable.h>
 #include <LibGfx/Color.h>
 #include <LibPDF/ObjectDerivatives.h>
 #include <LibPDF/Parser.h>
@@ -70,7 +71,9 @@ struct OutlineDict final : public RefCounted<OutlineDict> {
     OutlineDict() = default;
 };
 
-class Document final : public RefCounted<Document> {
+class Document final
+    : public RefCounted<Document>
+    , public Weakable<Document> {
 public:
     static RefPtr<Document> create(ReadonlyBytes bytes);
 
diff --git a/Userland/Libraries/LibPDF/Parser.cpp b/Userland/Libraries/LibPDF/Parser.cpp
index 744a88521a..20bc36fd00 100644
--- a/Userland/Libraries/LibPDF/Parser.cpp
+++ b/Userland/Libraries/LibPDF/Parser.cpp
@@ -39,7 +39,7 @@ Parser::Parser(ReadonlyBytes bytes)
 {
 }
 
-void Parser::set_document(RefPtr<Document> const& document)
+void Parser::set_document(WeakPtr<Document> const& document)
 {
     m_document = document;
 }
diff --git a/Userland/Libraries/LibPDF/Parser.h b/Userland/Libraries/LibPDF/Parser.h
index b19bc50bd8..b862bc67c2 100644
--- a/Userland/Libraries/LibPDF/Parser.h
+++ b/Userland/Libraries/LibPDF/Parser.h
@@ -7,6 +7,7 @@
 #pragma once
 
 #include <AK/NonnullRefPtrVector.h>
+#include <AK/WeakPtr.h>
 #include <LibPDF/Command.h>
 #include <LibPDF/Object.h>
 #include <LibPDF/Reader.h>
@@ -29,7 +30,7 @@ public:
     Parser(Badge<Document>, ReadonlyBytes);
 
     [[nodiscard]] ALWAYS_INLINE RefPtr<DictObject> const& trailer() const { return m_trailer; }
-    void set_document(RefPtr<Document> const&);
+    void set_document(WeakPtr<Document> const&);
 
     // Parses the header and initializes the xref table and trailer
     bool initialize();
@@ -139,7 +140,7 @@ private:
     bool consume(char);
 
     Reader m_reader;
-    RefPtr<Document> m_document;
+    WeakPtr<Document> m_document;
     RefPtr<XRefTable> m_xref_table;
     RefPtr<DictObject> m_trailer;
     Optional<LinearizationDictionary> m_linearization_dictionary;