RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 05:38:11 +00:00
Code Issues Activity Actions

WindowServer: Avoid doing sqrt() in double-click detection

Browse source 
Compare the distance travelled squared against the max distance squared
to avoid using sqrt().

Thanks to Nagy Tibor for the suggestion :^)
This commit is contained in:
Andreas Kling 2019-09-09 08:46:07 +02:00
parent 54caeb1f1a
commit c8be606acf
2 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Servers/WindowServer/WSWindowManager.cpp
View file

@ -20,7 +20,6 @@
#include <WindowServer/WSClientConnection.h>
#include <WindowServer/WSCursor.h>
#include <errno.h>
#include <math.h>
#include <stdio.h>
#include <time.h>
#include <unistd.h>
@ -641,9 +640,8 @@ void WSWindowManager::process_event_for_doubleclick(WSWindow& window, WSMouseEve
metadata.clock.start();
if (elapsed_since_last_click < m_double_click_speed) {
auto diff = event.position() - metadata.last_position;
auto distance_travelled = (int)sqrt(diff.x() * diff.x() + diff.y() * diff.y());
if (distance_travelled > 4) {
auto distance_travelled_squared = diff.x() * diff.x() + diff.y() * diff.y();
if (distance_travelled_squared > (m_max_distance_for_double_click * m_max_distance_for_double_click)) {
// too far; try again
metadata.clock.start();
} else {