RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:07:35 +00:00
Code Issues Activity Actions

Userland: Resolve -Woverloaded-virtual in LibGUI and SoundPlayer

Browse source 
Enable the warning project-wide. It catches when a non-virtual method
creates an overload set with a virtual method. This might cause
surprising overload resolution depending on how the method is invoked.
This commit is contained in:
Andrew Kaster 2022-01-03 01:34:29 -07:00 • committed by Brian Gianforcaro
parent ed3cb88898
commit c8cfd6661a
5 changed files with 7 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Applications/SoundPlayer/Common.h
View file

@ -13,10 +13,10 @@ class AutoSlider final : public GUI::Slider {
public:
~AutoSlider() override = default;
Function<void(int)> on_knob_released;
void set_value(int value)
virtual void set_value(int value, GUI::AllowCallback allow_callback = GUI::AllowCallback::Yes) override
{
if (!knob_dragging() && !mouse_is_down())
GUI::Slider::set_value(value);
GUI::Slider::set_value(value, allow_callback);
}
bool mouse_is_down() const { return m_mouse_is_down; }