RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:28:12 +00:00
Code Issues Activity Actions

Userland: Resolve -Woverloaded-virtual in LibGUI and SoundPlayer

Browse source 
Enable the warning project-wide. It catches when a non-virtual method
creates an overload set with a virtual method. This might cause
surprising overload resolution depending on how the method is invoked.
This commit is contained in:
Andrew Kaster 2022-01-03 01:34:29 -07:00 • committed by Brian Gianforcaro
parent ed3cb88898
commit c8cfd6661a
5 changed files with 7 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibGUI/IconView.cpp
View file

@ -682,7 +682,7 @@ void IconView::toggle_selection(ItemData& item_data)
if (!item_data.selected)
add_selection(item_data);
else
remove_selection(item_data);
remove_item_selection(item_data);
}
void IconView::toggle_selection(const ModelIndex& new_index)
@ -692,7 +692,7 @@ void IconView::toggle_selection(const ModelIndex& new_index)
toggle_selection(get_item_data(item_index));
}
void IconView::remove_selection(ItemData& item_data)
void IconView::remove_item_selection(ItemData& item_data)
{
if (!item_data.selected)
return;