RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:37:35 +00:00
Code Issues Activity Actions

Userland: Resolve -Woverloaded-virtual in LibGUI and SoundPlayer

Browse source 
Enable the warning project-wide. It catches when a non-virtual method
creates an overload set with a virtual method. This might cause
surprising overload resolution depending on how the method is invoked.
This commit is contained in:
Andrew Kaster 2022-01-03 01:34:29 -07:00 • committed by Brian Gianforcaro
parent ed3cb88898
commit c8cfd6661a
5 changed files with 7 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGUI/IconView.h
View file

@ -143,7 +143,7 @@ private:
void do_clear_selection();
bool do_add_selection(ItemData&);
void add_selection(ItemData&);
void remove_selection(ItemData&);
void remove_item_selection(ItemData&);
void toggle_selection(ItemData&);
int m_horizontal_padding { 5 };