mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 14:57:35 +00:00
Userland: Resolve -Woverloaded-virtual in LibGUI and SoundPlayer
Enable the warning project-wide. It catches when a non-virtual method creates an overload set with a virtual method. This might cause surprising overload resolution depending on how the method is invoked.
This commit is contained in:
parent
ed3cb88898
commit
c8cfd6661a
5 changed files with 7 additions and 8 deletions
|
@ -69,10 +69,10 @@ public:
|
|||
auto& gcf_params = static_cast<const GenericConvolutionFilter::Parameters&>(parameters);
|
||||
|
||||
ApplyCache apply_cache;
|
||||
apply(target_bitmap, target_rect, source_bitmap, source_rect, gcf_params, apply_cache);
|
||||
apply_with_cache(target_bitmap, target_rect, source_bitmap, source_rect, gcf_params, apply_cache);
|
||||
}
|
||||
|
||||
void apply(Bitmap& target, IntRect target_rect, const Bitmap& source, const IntRect& source_rect, const GenericConvolutionFilter::Parameters& parameters, ApplyCache& apply_cache)
|
||||
void apply_with_cache(Bitmap& target, IntRect target_rect, const Bitmap& source, const IntRect& source_rect, const GenericConvolutionFilter::Parameters& parameters, ApplyCache& apply_cache)
|
||||
{
|
||||
// The target area (where the filter is applied) must be entirely
|
||||
// contained by the source area. source_rect should be describing
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue