From c8dbcdb0bccd1fc8b08f5d802d2514295911e0dd Mon Sep 17 00:00:00 2001
From: Timothy Flynn <trflynn89@pm.me>
Date: Wed, 15 Sep 2021 13:34:18 -0400
Subject: [PATCH] LibUnicode: Do not compare generated file contents before
 writing

This is now covered by unicode_data.cmake after the superbuild changes.
---
 .../LibUnicode/GenerateUnicodeData.cpp           | 16 ++--------------
 .../LibUnicode/GenerateUnicodeLocale.cpp         | 16 ++--------------
 2 files changed, 4 insertions(+), 28 deletions(-)

diff --git a/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateUnicodeData.cpp b/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateUnicodeData.cpp
index 166da0820e..7b4435df46 100644
--- a/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateUnicodeData.cpp
+++ b/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateUnicodeData.cpp
@@ -125,18 +125,6 @@ static constexpr auto s_desired_fields = Array {
     "simple_lowercase_mapping"sv,
 };
 
-static void write_to_file_if_different(Core::File& file, StringView contents)
-{
-    auto const current_contents = file.read_all();
-
-    if (StringView { current_contents.bytes() } == contents)
-        return;
-
-    VERIFY(file.seek(0));
-    VERIFY(file.truncate(0));
-    VERIFY(file.write(contents));
-}
-
 static Vector<u32> parse_code_point_list(StringView const& list)
 {
     Vector<u32> code_points;
@@ -578,7 +566,7 @@ Optional<Script> script_from_string(StringView const& script);
 }
 )~~~");
 
-    write_to_file_if_different(file, generator.as_string_view());
+    file.write(generator.as_string_view());
 }
 
 static void generate_unicode_data_implementation(Core::File& file, UnicodeData const& unicode_data)
@@ -861,7 +849,7 @@ Optional<@enum_title@> @enum_snake@_from_string(StringView const& @enum_snake@)
 }
 )~~~");
 
-    write_to_file_if_different(file, generator.as_string_view());
+    file.write(generator.as_string_view());
 }
 
 static Vector<u32> flatten_code_point_ranges(Vector<CodePointRange> const& code_points)
diff --git a/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateUnicodeLocale.cpp b/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateUnicodeLocale.cpp
index 5ca7d38c81..957bdb229d 100644
--- a/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateUnicodeLocale.cpp
+++ b/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateUnicodeLocale.cpp
@@ -74,18 +74,6 @@ struct UnicodeLocaleData {
     size_t max_variant_size { 0 };
 };
 
-static void write_to_file_if_different(Core::File& file, StringView contents)
-{
-    auto const current_contents = file.read_all();
-
-    if (StringView { current_contents.bytes() } == contents)
-        return;
-
-    VERIFY(file.seek(0));
-    VERIFY(file.truncate(0));
-    VERIFY(file.write(contents));
-}
-
 static Optional<CanonicalLanguageID> parse_language(StringView language)
 {
     CanonicalLanguageID language_id {};
@@ -607,7 +595,7 @@ Optional<String> resolve_most_likely_territory(Unicode::LanguageID const& langua
 }
 )~~~");
 
-    write_to_file_if_different(file, generator.as_string_view());
+    file.write(generator.as_string_view());
 }
 
 static void generate_unicode_locale_implementation(Core::File& file, UnicodeLocaleData& locale_data)
@@ -1144,7 +1132,7 @@ Optional<String> resolve_most_likely_territory(Unicode::LanguageID const& langua
 }
 )~~~");
 
-    write_to_file_if_different(file, generator.as_string_view());
+    file.write(generator.as_string_view());
 }
 
 int main(int argc, char** argv)