RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:47:35 +00:00
Code Issues Activity Actions

AK: Disable use of consteval in String::from_utf8_short_string for Apple

Browse source 
This causes an ICE on older versions of clang, and Apple's clang is
currently based on such a version.
This commit is contained in:
Timothy Flynn 2023-01-20 15:03:04 -05:00 • committed by Linus Groh
parent 95d1678553
commit c8e25a71e0
1 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
AK/String.h
View file

@ -23,6 +23,13 @@ namespace Detail {
class StringData; class StringData;
} }
// FIXME: Remove this when Apple Clang fully supports consteval.
#if defined(AK_OS_MACOS)
# define AK_SHORT_STRING_CONSTEVAL constexpr
#else
# define AK_SHORT_STRING_CONSTEVAL consteval
#endif
// String is a strongly owned sequence of Unicode code points encoded as UTF-8. // String is a strongly owned sequence of Unicode code points encoded as UTF-8.
// The data may or may not be heap-allocated, and may or may not be reference counted. // The data may or may not be heap-allocated, and may or may not be reference counted.
// There is no guarantee that the underlying bytes are null-terminated. // There is no guarantee that the underlying bytes are null-terminated.
@ -51,7 +58,7 @@ public:
// Creates a new String from a short sequence of UTF-8 encoded code points. If the provided string // Creates a new String from a short sequence of UTF-8 encoded code points. If the provided string
// does not fit in the short string storage, a compilation error will be emitted. // does not fit in the short string storage, a compilation error will be emitted.
static consteval String from_utf8_short_string(StringView string) static AK_SHORT_STRING_CONSTEVAL String from_utf8_short_string(StringView string)
{ {
VERIFY(string.length() <= MAX_SHORT_STRING_BYTE_COUNT); VERIFY(string.length() <= MAX_SHORT_STRING_BYTE_COUNT);